Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dashboard): Filters for activity feed #7255

Merged
merged 37 commits into from
Dec 12, 2024
Merged

feat(dashboard): Filters for activity feed #7255

merged 37 commits into from
Dec 12, 2024

Conversation

scopsy
Copy link
Contributor

@scopsy scopsy commented Dec 9, 2024 •
edited
Loading

What changed? Why was the change needed?

  • New reusable multi-faced filter component
  • Applied filters on the activity feed page

Screenshots

https://www.loom.com/share/f818c89fcc264ce3b5d77c403f78898e
CleanShot 2024-12-10 at 13 42 17@2x

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

@scopsy scopsy changed the title feat(dashboard): Filters for activity feed feat(dashboard): Filters for activity feed - DRAFT Dec 9, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 10, 2024 •
edited
Loading

Open in Stackblitz

@novu/client

npm i https://pkg.pr.new/novuhq/novu/@novu/client@7255

@novu/framework

npm i https://pkg.pr.new/novuhq/novu/@novu/framework@7255

@novu/js

npm i https://pkg.pr.new/novuhq/novu/@novu/js@7255

@novu/nest

npm i https://pkg.pr.new/novuhq/novu/@novu/nest@7255

@novu/headless

npm i https://pkg.pr.new/novuhq/novu/@novu/headless@7255

@novu/nextjs

npm i https://pkg.pr.new/novuhq/novu/@novu/nextjs@7255

@novu/node

npm i https://pkg.pr.new/novuhq/novu/@novu/node@7255

@novu/notification-center

npm i https://pkg.pr.new/novuhq/novu/@novu/notification-center@7255

novu

npm i https://pkg.pr.new/novuhq/novu@7255

@novu/providers

npm i https://pkg.pr.new/novuhq/novu/@novu/providers@7255

@novu/react

npm i https://pkg.pr.new/novuhq/novu/@novu/react@7255

@novu/react-native

npm i https://pkg.pr.new/novuhq/novu/@novu/react-native@7255

@novu/shared

npm i https://pkg.pr.new/novuhq/novu/@novu/shared@7255

@novu/stateless

npm i https://pkg.pr.new/novuhq/novu/@novu/stateless@7255

commit: 3f62c06

LetItRock
LetItRock requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scopsy something is broken here
Screenshot 2024-12-12 at 10 12 34

Also we don't handle properly the pagination. It allows me to go to the next empty page and at the result I see this:
Screenshot 2024-12-12 at 10 16 42

The workflows list can be huge and should be scrollable:
Screenshot 2024-12-12 at 10 21 56

Missing the Chat in the filter:
Screenshot 2024-12-12 at 10 22 16

The table is loading when picking the item from the list:

Screen.Recording.2024-12-12.at.10.24.58.mov

@LetItRock
Copy link
Contributor

LetItRock commented Dec 12, 2024 •
edited
Loading

No reset button on channels filter, same about the workflows
Screenshot 2024-12-12 at 10 29 24

@scopsy scopsy merged commit 83ea199 into new-activity-feed-page Dec 12, 2024
8 checks passed
@scopsy scopsy deleted the v2-filters-test-playground branch December 12, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SokratisVidros SokratisVidros SokratisVidros requested changes

@LetItRock LetItRock LetItRock requested changes

Assignees
No one assigned
Labels
@novu/api @novu/dal @novu/dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scopsy @LetItRock @SokratisVidros